On Wed, 12 Jan 2011, Eric B Munson wrote: > On Wed, 12 Jan 2011, Christoph Lameter wrote: > > Use t instead of p? Its a local variable after all. > > I don't find t any more informative than p. As a newcomer to most of this code > informative variable names, even for local variables, is a huge help. Local variables are short because they are defined close to the point of use. tsk is not that informative and the notion of a "task" can refer to various. However, when I see struct task_struct *t; I know what it refers to. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>