On 09/01/2017 03:01 PM, Anshuman Khandual wrote:
> VMA and its address bounds checks are too late in this function.
> They must have been verified earlier in the page fault sequence.
> Hence just remove them.
>
> Suggested-by: Vlastimil Babka <vbabka@xxxxxxx>
> Signed-off-by: Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx>
Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
> ---
> mm/mempolicy.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 618ab12..3509b84 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -2172,17 +2172,12 @@ int mpol_misplaced(struct page *page, struct vm_area_struct *vma, unsigned long
> int polnid = -1;
> int ret = -1;
>
> - BUG_ON(!vma);
> -
> pol = get_vma_policy(vma, addr);
> if (!(pol->flags & MPOL_F_MOF))
> goto out;
>
> switch (pol->mode) {
> case MPOL_INTERLEAVE:
> - BUG_ON(addr >= vma->vm_end);
> - BUG_ON(addr < vma->vm_start);
> -
> pgoff = vma->vm_pgoff;
> pgoff += (addr - vma->vm_start) >> PAGE_SHIFT;
> polnid = offset_il_node(pol, vma, pgoff);
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
