2017-08-16 12:51 GMT+08:00 Minchan Kim <minchan@xxxxxxxxxx>: > On Wed, Aug 16, 2017 at 10:49:14AM +0800, Hui Zhu wrote: >> Hi Minchan, >> >> 2017-08-16 10:13 GMT+08:00 Minchan Kim <minchan@xxxxxxxxxx>: >> > Hi Hui, >> > >> > On Mon, Aug 14, 2017 at 05:56:30PM +0800, Hui Zhu wrote: >> >> After commit e2846124f9a2 ("zsmalloc: zs_page_migrate: skip unnecessary >> > >> > This patch is not merged yet so the hash is invalid. >> > That means we may fold this patch to [1] in current mmotm. >> > >> > [1] zsmalloc-zs_page_migrate-skip-unnecessary-loops-but-not-return-ebusy-if-zspage-is-not-inuse-fix.patch >> > >> >> loops but not return -EBUSY if zspage is not inuse") zs_page_migrate >> >> can handle the ZS_EMPTY zspage. >> >> >> >> But I got some false in zs_page_isolate: >> >> if (get_zspage_inuse(zspage) == 0) { >> >> spin_unlock(&class->lock); >> >> return false; >> >> } >> > >> > I also realized we should make zs_page_isolate succeed on empty zspage >> > because we allow the empty zspage migration from now on. >> > Could you send a patch for that as well? >> >> OK. I will make a patch for that later. > > Please send the patch so I want to fold it to [1] before Andrew is going > to send [1] to Linus. > > Thanks. Done. Thanks, Hui -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>