>> >> -static inline unsigned long zone_numa_state(struct zone *zone, >> +static inline unsigned long zone_numa_state_snapshot(struct zone *zone, >> enum zone_numa_stat_item item) >> { >> long x = atomic_long_read(&zone->vm_numa_stat[item]); >> + int cpu; >> + >> + for_each_online_cpu(cpu) >> + x += per_cpu_ptr(zone->pageset, cpu)->vm_numa_stat_diff[item]; >> >> return x; >> } > > This does not appear to be related to the current patch. It either > should be merged with the previous patch or stand on its own. > OK. I can move it to an individual patch if it does not make anyone unhappy. Since it is not graceful to introduce any functionality change in first patch. >> diff --git a/mm/vmstat.c b/mm/vmstat.c >> index 5a7fa30..c7f50ed 100644 >> --- a/mm/vmstat.c >> +++ b/mm/vmstat.c >> @@ -30,6 +30,8 @@ >> >> #include "internal.h" >> >> +#define NUMA_STAT_THRESHOLD 32765 >> + > > This should be expressed in terms of the type and not a hard-coded value. > OK, Thanks. I will follow it. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>