Hi Sergey, On Tue, Aug 08, 2017 at 04:02:26PM +0900, Sergey Senozhatsky wrote: > On (08/08/17 15:50), Minchan Kim wrote: > > With on-stack-bio, rw_page interface doesn't provide a clear performance > > benefit for zram and surely has a maintenance burden, so remove the > > last user to remove rw_page completely. > > OK, never really liked it, I think we had that conversation before. > > as far as I remember, zram_rw_page() was the reason we had to do some > tricks with init_lock to make lockdep happy. may be now we can "simplify" > the things back. I cannot remember. Blame my brain. ;-) Anyway, it's always welcome to make thing simple. Could you send a patch after settle down this patchset? > > > > Cc: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx> > > Signed-off-by: Minchan Kim <minchan@xxxxxxxxxx> > > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx> Thanks for the review! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>