Re: [PATCH v13 5/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/03/2017 04:13 PM, Pankaj Gupta wrote:

+        /* Allocate space for find_vqs parameters */
+        vqs = kcalloc(nvqs, sizeof(*vqs), GFP_KERNEL);
+        if (!vqs)
+                goto err_vq;
+        callbacks = kmalloc_array(nvqs, sizeof(*callbacks), GFP_KERNEL);
+        if (!callbacks)
+                goto err_callback;
+        names = kmalloc_array(nvqs, sizeof(*names), GFP_KERNEL);
is size here (integer) intentional?


Sorry, I didn't get it. Could you please elaborate more?



+        if (!names)
+                goto err_names;
+
+        callbacks[0] = balloon_ack;
+        names[0] = "inflate";
+        callbacks[1] = balloon_ack;
+        names[1] = "deflate";
+
+        i = 2;
+        if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_STATS_VQ)) {
+                callbacks[i] = stats_request;
just thinking if memory for callbacks[3] & names[3] is allocated?


Yes, the above kmalloc_array allocated them.


Best,
Wei

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]
  Powered by Linux