On Wed 02-08-17 17:55:22, Andrea Arcangeli wrote: > On Wed, Aug 02, 2017 at 03:34:41PM +0300, Mike Rapoport wrote: > > I surely can take care of CRIU, but I don't know if QEMU or certain > > database application that uses userfaultfd rely on this API, not mentioning > > there maybe other unknown users. > > > > Andrea, what do you think? > > The manpage would need updates, from v4.11 to v4.13 -ENOSPC, from v4.1 > -ESRCH and I don't see the benefit and it just looks confusion for > nothing, but if somebody feel strongly about it and does the work (and > risks to take the blame if something breaks...) I wouldn't be against > it, it won't make much of a difference anyway. > > The reason I don't see any benefit in code readability is that I don't > see ESRCH as an obviously better retval, because if you grep for ESRCH > you'll see it's a failure to find a process with a certain pid, it is > an obvious retval when you're dealing with processes and pids, but we > never search pids and in fact the pid and the process may be already > gone but we still won't return ESRCH. UFFDIO_COPY never takes a pid as > parameter anywhere so why to return ESRCH? ESRCH refers to "no such process". Strictly speaking userfaultfd code is about a mm which is gone but that is a mere detail. In fact the owner of the mm is gone as well. You might not refer to the process by its pid but you are surely refer to a process via its address space. That's why I think this error code is more appropriate. But as I've said, this might be really risky to change. My impression was that userfaultfd is not widely used yet and those can be fixed easily but if that is not the case then we have to live with the current ENOSPC. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
