On Fri 28-07-17 09:05:17, Johannes Weiner wrote: > On Fri, Jul 28, 2017 at 11:07:51AM +0200, Michal Hocko wrote: [...] > > From: Michal Hocko <mhocko@xxxxxxxx> > > Date: Fri, 28 Jul 2017 11:02:51 +0200 > > Subject: [PATCH] mm: rename global_page_state to global_zone_page_state > > > > global_page_state is error prone as a recent bug report pointed out [1]. > > It only returns proper values for zone based counters as the enum it > > gets suggests. We already have global_node_page_state so let's rename > > global_page_state to global_zone_page_state to be more explicit here. > > All existing users seems to be correct > > $ git grep "global_page_state(NR_" | sed 's@.*(\(NR_[A-Z_]*\)).*@\1@' | sort | uniq -c > > 2 NR_BOUNCE > > 2 NR_FREE_CMA_PAGES > > 11 NR_FREE_PAGES > > 1 NR_KERNEL_STACK_KB > > 1 NR_MLOCK > > 2 NR_PAGETABLE > > > > This patch shouldn't introduce any functional change. > > > > [1] http://lkml.kernel.org/r/201707260628.v6Q6SmaS030814@xxxxxxxxxxxxxxxxxxx > > > > Signed-off-by: Michal Hocko <mhocko@xxxxxxxx> > > Yeah I think that's a good idea. I suspect Mel wanted to keep churn in > unrelated callsites down when he introduced the node stuff, since that > was already a big patch series. It makes sense to clean this up now. yeah that would make sense. > Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx> Thanks! Could you post both patches when sending to Andrew, please? -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
