On Wed, Dec 22, 2010 at 04:27:32PM -0800, Andrew Morton wrote:
> > static struct task_struct *idle_thread_array[NR_CPUS] __cpuinitdata ;
> > @@ -198,6 +200,8 @@
> > {
> > int cpuid, phys_id;
> > unsigned long timeout;
> > + u8 cpu_probe_on = 0;
>
> Unneeded initialisation.
>
> Does this cause an unused var warning when
> CONFIG_ARCH_CPU_PROBE_RELEASE=n?
>
I am trying to avoid too much ifdef here, it seems it take an unused var
warining when CONFIG_ARCH_CPU_PROBE_RELEASE=n. good catching.
I will figure out a better method.
> > + struct cpuinfo_x86 *c;
> >
> > /*
> > * If waken up by an INIT in an 82489DX configuration
> >
> > ...
> >
> > +#ifdef CONFIG_ARCH_CPU_PROBE_RELEASE
> > +/*
> > + * Put the logical cpu into a new sokect, and encapsule it into core 0.
>
> That comment needs help.
>
Agree, the comment is too simple, should add better documents for function
fake_cpu_socket_info.
--
Thanks & Regards,
Shaohui
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>