On Wed, 22 Dec 2010 17:38:44 -0800 (PST) David Rientjes <rientjes@xxxxxxxxxx> wrote: > On Wed, 22 Dec 2010, Andrew Morton wrote: > > > > Index: linux-hpe4/mm/memory_hotplug.c > > > =================================================================== > > > --- linux-hpe4.orig/mm/memory_hotplug.c 2010-11-30 12:40:43.757622001 +0800 > > > +++ linux-hpe4/mm/memory_hotplug.c 2010-11-30 14:02:33.877622002 +0800 > > > @@ -924,3 +924,63 @@ > > > } > > > #endif /* CONFIG_MEMORY_HOTREMOVE */ > > > EXPORT_SYMBOL_GPL(remove_memory); > > > + > > > +#ifdef CONFIG_DEBUG_FS > > > +#include <linux/debugfs.h> > > > + > > > +static struct dentry *memhp_debug_root; > > > + > > > +static ssize_t add_node_store(struct file *file, const char __user *buf, > > > + size_t count, loff_t *ppos) > > > +{ > > > + nodemask_t mask; > > > > NODEMASK_ALLOC()? > > > > We traditionally haven't been using NODEMASK_ALLOC() in sysfs (or, in this > case, debugfs) functions because they're never deep in a call chain. Even > for 4K node support, which isn't a supported config on any arch that > allows CONFIG_MEMORY_HOTPLUG, this would only be 512 bytes on the short > stack. I bet linux-2.6.227 supports a meganode. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>