On Sat, Jul 15, 2017 at 10:23:15PM -0400, Dennis Zhou wrote: > From: "Dennis Zhou (Facebook)" <dennisszhou@xxxxxxxxx> > > This patch adds two optimizations to the allocation path. The first is > to not consider a chunk if the requested allocation cannot fit in the > chunk's contig_hint. The benefit is that this avoids unncessary scanning > over a chunk as the assumption is memory pressure is high and creating a > new chunk has minimal consequences. This may fail when the contig_hint > has poor alignment, but again we fall back on the high memory pressure > argument. > > The second is just a fail-fast mechanism. When allocating, a offset is > identified within a block and then scanning is used to see if it will > fit. An offset should never be returned unless it is known to fit, so > here we just bind the scanning to the size of a block. > > Signed-off-by: Dennis Zhou <dennisszhou@xxxxxxxxx> Looks good to me and there's nothing wrong with these two optimizations being in a separate patch but they might be too little to help reviewing / debugging in any noticeable way. It'd be great if more significant parts can be separated out. If not, this is fine too. Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
