[bug report] percpu: add tracepoint support for percpu memory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Dennis Zhou,

This is a semi-automatic email about new static checker warnings.

The patch df95e795a722: "percpu: add tracepoint support for percpu
memory" from Jun 19, 2017, leads to the following Smatch complaint:

    mm/percpu-km.c:88 pcpu_destroy_chunk()
    warn: variable dereferenced before check 'chunk' (see line 86)

mm/percpu-km.c
    85		pcpu_stats_chunk_dealloc();
    86		trace_percpu_destroy_chunk(chunk->base_addr);
                                           ^^^^^^^^^^^^^^^^
There should probably be a NULL check here?

    87	
    88		if (chunk && chunk->data)
    89			__free_pages(chunk->data, order_base_2(nr_pages));
    90		pcpu_free_chunk(chunk);

regards,
dan carpenter

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]
  Powered by Linux