On Thu, Jun 22, 2017 at 08:21:14PM +0200, Michal Hocko wrote: >On Thu 22-06-17 12:18:44, Wei Yang wrote: >[...] >> -'valid_zones' : read-only: designed to show which zones this memory block >> - can be onlined to. >> - The first column shows it's default zone. >> +'valid_zones' : read-only: shows different information based on state. >> + When state is online, it is designed to show the >> + zone name this memory block is onlined to. >> + When state is offline, it is designed to show which zones >> + this memory block can be onlined to. The first column >> + shows it's default zone. > >I do not think we really need to touch this. First of all the last >sentence is not really correct. The ordering of zones doesn't tell which >zone will be onlined by default. This is indeed a change of behavior of >my patch. I am just not sure anybody depends on that. I can fix it up >but again the old semantic was just awkward and I didn't feel like I >should keep it. Also I plan to change this behavior again with planned >patches. I would like to get rid of the non-overlapping zones >restriction so the wording would have to change again. Sure, look forward your up coming patches. > >That being said, let's keep the wording as it is now. > >Thanks! >-- >Michal Hocko >SUSE Labs -- Wei Yang Help you, Help me
Attachment:
signature.asc
Description: PGP signature
