On Fri 16-06-17 10:33:50, Andrew Morton wrote: > On Fri, 16 Jun 2017 17:23:35 +0800 Wei Yang <richard.weiyang@xxxxxxxxx> wrote: > > > In function move_pfn_range_to_zone(), memmap_init_zone() will call > > set_page_links for each page. > > Well, no. There are several types of pfn's for which > memmap_init_zone() will not call > __init_single_page()->set_page_links(). Probably the code is OK, as > those are pretty screwy pfn types. But I'd like to see some > confirmation that this patch is OK for all such pfns, now and in the > future? Yes it work properly for the hotplugable memory. If not then it is memmap_init_zone to be fixed rather than duplicate the thig outside of this function. Acked-by: Michal Hocko <mhocko@xxxxxxxx> -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
