Re: [PATCH] mm: avoid taking zone lock in pagetypeinfo_showmixed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/21/2017 01:47 PM, Vinayak Menon wrote:
> pagetypeinfo_showmixedcount_print is found to take a lot of
> time to complete and it does this holding the zone lock and
> disabling interrupts. In some cases it is found to take more
> than a second (On a 2.4GHz,8Gb RAM,arm64 cpu). Avoid taking
> the zone lock similar to what is done by read_page_owner,
> which means possibility of inaccurate results.
> 
> Signed-off-by: Vinayak Menon <vinmenon@xxxxxxxxxxxxxx>

Acked-by: Vlastimil Babka <vbabka@xxxxxxx>

walk_zones_in_node() becomes quite ugly though, multiple bool params are
not nice, and both are there for single special cases. Wonder if
replacing this with a new for_each_zone_node() helper would make this
better. OTOH it's now isolated only to vmstat.c.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]
  Powered by Linux