On Tue, Jun 20, 2017 at 3:05 AM, Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> wrote: > On Mon, Jun 19 2017, Vlastimil Babka <vbabka@xxxxxxx> wrote: > >> On 06/19/2017 03:54 PM, Hao Lee wrote: >>> The variable current_order decreases from MAX_ORDER-1 to order, so the >>> condition current_order <= MAX_ORDER-1 is always true. >>> >>> Signed-off-by: Hao Lee <haolee.swjtu@xxxxxxxxx> >> >> Sounds right. >> >> Acked-by: Vlastimil Babka <vbabka@xxxxxxx> > > current_order and order are both unsigned, and if order==0, > current_order >= order is always true, and we may decrement > current_order past 0 making it UINT_MAX... A comment would be in order, > though. Thanks, I didn't notice unsigned subtraction. Sorry about that. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
