Re: [mmotm:master 230/317] arch/sparc/mm/extable.c:16:1: error: conflicting types for 'search_extable'

[Thomas Meyer <thomas@xxxxxxxx>]

Am 17.06.2017 um 02:07 schrieb kbuild test robot <fengguang.wu@xxxxxxxxx>:

tree:   git://git.cmpxchg.org/linux-mmotm.git master
head:   8c91e2a1ea04c0c1e29415c62f151e77de2291f8
commit: ad8aa0a41610e2b5225067c38a9020f6def8a940 [230/317] lib/extable.c: use bsearch() library function in search_extable()
config: sparc-defconfig (attached as .config)
compiler: sparc-linux-gcc (GCC) 6.2.0
reproduce:
       wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
       chmod +x ~/bin/make.cross
       git checkout ad8aa0a41610e2b5225067c38a9020f6def8a940
       # save the attached .config to linux build tree
       make.cross ARCH=sparc

All errors (new ones prefixed by >>):

arch/sparc/mm/extable.c:16:1: error: conflicting types for 'search_extable'

   search_extable(const struct exception_table_entry *start,
   ^~~~~~~~~~~~~~
  In file included from arch/sparc/mm/extable.c:6:0:
  include/linux/extable.h:11:1: note: previous declaration of 'search_extable' was here
   search_extable(const struct exception_table_entry *first,
   ^~~~~~~~~~~~~~

Oops, of course I only did test against x86_64...

But one question regarding the range entries:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/sparc/mm/extable.c#n60

Shouldn't the range search skip deleted entries? Or does something else ensure consistency?

I'll check all other archs for arch-specific implementation and send v3 then.

Sorry for the fuss and kind regards

Thomas 

vim +/search_extable +16 arch/sparc/mm/extable.c

^1da177e Linus Torvalds 2005-04-16  10            struct exception_table_entry *finish)
^1da177e Linus Torvalds 2005-04-16  11  {
^1da177e Linus Torvalds 2005-04-16  12  }
^1da177e Linus Torvalds 2005-04-16  13  
^1da177e Linus Torvalds 2005-04-16  14  /* Caller knows they are in a range if ret->fixup == 0 */
^1da177e Linus Torvalds 2005-04-16  15  const struct exception_table_entry *
^1da177e Linus Torvalds 2005-04-16 @16  search_extable(const struct exception_table_entry *start,
^1da177e Linus Torvalds 2005-04-16  17             const struct exception_table_entry *last,
^1da177e Linus Torvalds 2005-04-16  18             unsigned long value)
^1da177e Linus Torvalds 2005-04-16  19  {

:::::: The code at line 16 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

<.config.gz>

Attachment: smime.p7s
Description: S/MIME cryptographic signature