On Fri, Jun 09, 2017 at 09:27:15AM +0000, Ard Biesheuvel wrote: > On 9 June 2017 at 09:22, Mark Rutland <mark.rutland@xxxxxxx> wrote: > > On Fri, Jun 09, 2017 at 08:22:26AM +0000, Ard Biesheuvel wrote: > >> v4: - use pud_bad/pmd_bad instead of pud_huge/pmd_huge, which don't require > >> changes to hugetlb.h, and give us what we need on all architectures > >> - move WARN_ON_ONCE() calls out of conditionals > > ^^^ Ah, sorry. Clearly I scanned this too quickly. > >> + WARN_ON_ONCE(pud_bad(*pud)); > >> + if (pud_none(*pud) || pud_bad(*pud)) > >> return NULL; > > > > Nit: the WARN_ON_ONCE() can be folded into the conditional: > > > > if (pud_none(*pud) || WARN_ON_ONCE(pud_bad(*pud))) > > reutrn NULL; > Actually, it was Dave who requested them to be taken out of the conditional. Fair enough. My ack stands, either way! Thanks, Mark. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
