On 06/08/2017 04:36 AM, Ard Biesheuvel wrote: > @@ -287,10 +288,10 @@ struct page *vmalloc_to_page(const void *vmalloc_addr) > if (p4d_none(*p4d)) > return NULL; > pud = pud_offset(p4d, addr); > - if (pud_none(*pud)) > + if (pud_none(*pud) || WARN_ON_ONCE(pud_huge(*pud))) > return NULL; > pmd = pmd_offset(pud, addr); > - if (pmd_none(*pmd)) > + if (pmd_none(*pmd) || WARN_ON_ONCE(pmd_huge(*pmd))) > return NULL; Seems sane to me. It might be nice to actually comment this, though, on why huge vmalloc_to_page() is unsupported. Also, not a big deal, but I tend to filter out the contents of WARN_ON_ONCE() when trying to figure out what code does, so I think I'd rather this be: WARN_ON_ONCE(pmd_huge(*pmd)); if (pmd_none(*pmd) || pmd_huge(*pmd)) ... But, again, not a big deal. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
