[PATCH] mm: correct the comment when reclaimed pages exceed the scanned pages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The commit e1587a494540 ("mm: vmpressure: fix sending wrong events on
underflow") declare that reclaimed pages exceed the scanned pages due
to the thp reclaim. it is incorrect because THP will be spilt to normal
page and loop again. which will result in the scanned pages increment.

Signed-off-by: zhongjiang <zhongjiang@xxxxxxxxxx>
---
 mm/vmpressure.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mm/vmpressure.c b/mm/vmpressure.c
index 6063581..0e91ba3 100644
--- a/mm/vmpressure.c
+++ b/mm/vmpressure.c
@@ -116,8 +116,9 @@ static enum vmpressure_levels vmpressure_calc_level(unsigned long scanned,
 
 	/*
 	 * reclaimed can be greater than scanned in cases
-	 * like THP, where the scanned is 1 and reclaimed
-	 * could be 512
+	 * like reclaimed slab pages, shrink_node just add
+	 * reclaimed page without a related increment to
+	 * scanned pages.
 	 */
 	if (reclaimed >= scanned)
 		goto out;
-- 
1.7.12.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]
  Powered by Linux