Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx> writes: > On Thu, May 25, 2017 at 02:46:27PM +0800, Huang, Ying wrote: >> From: Huang Ying <ying.huang@xxxxxxxxx> >> >> The .rw_page in struct block_device_operations is used by the swap >> subsystem to read/write the page contents from/into the corresponding >> swap slot in the swap device. To support the THP (Transparent Huge >> Page) swap optimization, the .rw_page is enhanced to support to >> read/write THP if possible. >> >> Signed-off-by: "Huang, Ying" <ying.huang@xxxxxxxxx> >> Cc: Johannes Weiner <hannes@xxxxxxxxxxx> >> Cc: Minchan Kim <minchan@xxxxxxxxxx> >> Cc: Dan Williams <dan.j.williams@xxxxxxxxx> >> Cc: Ross Zwisler <ross.zwisler@xxxxxxxxx> >> Cc: Vishal L Verma <vishal.l.verma@xxxxxxxxx> >> Cc: Jens Axboe <axboe@xxxxxxxxx> >> Cc: linux-nvdimm@xxxxxxxxxxxx >> --- >> drivers/block/brd.c | 6 +++++- >> drivers/block/zram/zram_drv.c | 2 ++ >> drivers/nvdimm/btt.c | 4 +++- >> drivers/nvdimm/pmem.c | 42 +++++++++++++++++++++++++++++++----------- >> 4 files changed, 41 insertions(+), 13 deletions(-) > > The changes in brd.c, zram_drv.c and pmem.c look good to me. For those bits > you can add: > > Reviewed-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx> Thanks! > I think we still want Vishal to make sure that the BTT changes are okay. I > don't know that code well enough to know whether it's safe to throw 512 pages > at btt_[read|write]_pg(). > > Also, Ying, next time can you please CC me (and probably the linux-nvdimm > list) on the whole series? It would give us more context on what the larger > change is, allow us to see the cover letter, allow us to test with all the > patches in the series, etc. It's pretty easy for reviewers to skip over the > patches we don't care about or aren't in our area. Sure. Best Regards, Huang, Ying > Thanks, > - Ross -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
