On Mon, Mar 06, 2017 at 11:30:24AM +0100, Michal Hocko wrote: > +void *kvmalloc_node(size_t size, gfp_t flags, int node) > +{ > + gfp_t kmalloc_flags = flags; > + void *ret; > + > + /* > + * vmalloc uses GFP_KERNEL for some internal allocations (e.g page tables) > + * so the given set of flags has to be compatible. > + */ > + WARN_ON_ONCE((flags & GFP_KERNEL) != GFP_KERNEL); Hm, there are quite a few locations in the kernel that do something like: __vmalloc(len, GFP_NOFS, PAGE_KERNEL); According to your patch, vmalloc can't really do GFP_NOFS, right? -- Thanks, Sasha -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href