On 05/23/2017 09:02 AM, Christoph Hellwig wrote: > On Mon, May 22, 2017 at 02:11:49PM -0700, Andrew Morton wrote: >> On Mon, 22 May 2017 16:47:42 +0530 Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx> wrote: >> >>> There are many places where we define size either left shifting integers >>> or multiplying 1024s without any generic definition to fall back on. But >>> there are couples of (powerpc and lz4) attempts to define these standard >>> memory sizes. Lets move these definitions to core VM to make sure that >>> all new usage come from these definitions eventually standardizing it >>> across all places. >> >> Grep further - there are many more definitions and some may now >> generate warnings. >> >> Newly including mm.h for these things seems a bit heavyweight. I can't >> immediately think of a more appropriate place. Maybe printk.h or >> kernel.h. > > IFF we do these kernel.h is the right place. And please also add the > MiB & co variants for the binary versions right next to the decimal > ones. Those defined in the patch are binary, not decimal. Do we even need decimal ones? > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@xxxxxxxxx. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a> > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
