On Fri, Dec 10, 2010 at 01:03:01AM +0900, Minchan Kim wrote: > On Fri, Dec 10, 2010 at 12:59 AM, Minchan Kim <minchan.kim@xxxxxxxxx> wrote: > > On Thu, Dec 09, 2010 at 11:18:18AM +0000, Mel Gorman wrote: > >> When kswapd wakes up, it reads its order and classzone from pgdat and > >> calls balance_pgdat. While its awake, it potentially reclaimes at a high > >> order and a low classzone index. This might have been a once-off that > >> was not required by subsequent callers. However, because the pgdat > >> values were not reset, they remain artifically high while > >> balance_pgdat() is running and potentially kswapd enters a second > >> unnecessary reclaim cycle. Reset the pgdat order and classzone index > >> after reading. > >> > >> Signed-off-by: Mel Gorman <mel@xxxxxxxxx> > > Reviewed-by: Minchan Kim <minchan.kim@xxxxxxxxx> > > Nitpick. > Shouldn't this patch be merged with 1/6? > I don't think so as it's a standalone fix. For example, if this was merged on its own, the "order" should still be reset after reading. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>