On 19 May 2017, at 12:02, Mel Gorman wrote: > On Fri, May 19, 2017 at 06:43:37PM +0530, Anshuman Khandual wrote: >> On 04/21/2017 09:34 AM, Anshuman Khandual wrote: >>> On 04/21/2017 02:17 AM, Zi Yan wrote: >>>> From: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx> >>>> >>>> Introduce a separate check routine related to MPOL_MF_INVERT flag. >>>> This patch just does cleanup, no behavioral change. >>> >>> Can you please send it separately first, this should be debated >>> and merged quickly and not hang on to the series if we have to >>> respin again. >>> >>> Reviewed-by: Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx> >> >> Mel/Andrew, >> >> This does not have any functional changes and very much independent. >> Can this clean up be accepted as is ? In that case we will have to >> carry one less patch in the series which can make the review process >> simpler. >> > > As you say, there is no functional change but the helper name is vague > and gives no hint to what's it's checking for. It's somewhat tolerable as > it is as it's obvious what is being checked but the same is not true with > the helper name. > > -- > Mel Gorman > SUSE Labs Does queue_pages_invert_nodemask_check() work? I can change the helper name in the next version. -- Best Regards Yan Zi
Attachment:
signature.asc
Description: OpenPGP digital signature
