On 05/17/2017 05:36 PM, Tejun Heo wrote: > Hello, Waiman. > > On Mon, May 15, 2017 at 09:34:07AM -0400, Waiman Long wrote: >> The debug cgroup currently resides within cgroup-v1.c and is enabled >> only for v1 cgroup. To enable the debug cgroup also for v2, it >> makes sense to put the code into its own file as it will no longer >> be v1 specific. The only change in this patch is the expansion of >> cgroup_task_count() within the debug_taskcount_read() function. >> >> Signed-off-by: Waiman Long <longman@xxxxxxxxxx> > I don't mind enabling the debug controller for v2 but let's please > hide it behind an unwieldy boot param / controller name so that it's > clear that its interface isn't expected to be stable. > > Thanks. > The controller name is "debug". So it is pretty obvious what it is for. However, the config prompt of "Example controller" is indeed a bit vague. So I think we can make the prompt more descriptive here. As for boot param, are you saying something like "cgroup_debug" has to be specified in the command line also to have this controller activated even if the CGROUP_DEBUG config parameter is specified? I am fine with that if you think it is necessary. Regards, Longman -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href
