On Tue, May 16, 2017 at 04:18:46PM +0200, Peter Zijlstra wrote: > On Tue, Apr 25, 2017 at 02:40:44PM +0900, Byungchul Park wrote: > > On Mon, Apr 24, 2017 at 12:17:47PM +0200, Peter Zijlstra wrote: > > > > My complaint is mostly about naming.. and "hist_gen_id" might be a > > > better name. > > > > Ah, I also think the name, 'work_id', is not good... and frankly I am > > not sure if 'hist_gen_id' is good, either. What about to apply 'rollback', > > which I did for locks in irq, into works of workqueues? If you say yes, > > I will try to do it. > > If the rollback thing works, that's fine too. If it gets ugly, stick > with something like 'hist_id'. I really want to implement it with rollback.. But it also needs to introduce new fields to distinguish between works which are all normal process contexts. I will do this with renaming instead of applying rollback. Thank you. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>