On Wed, 17 May 2017, Wei Yang wrote: > This patch serial could be divided into two parts. > > First three patches refine and adds slab sysfs. > Second three patches rename slab sysfs. These changes will break the slabinfo tool in linux/tools/vm/slabinfo.c. Please update it as well. > 1. Refine slab sysfs > > There are four level slabs: levels? Maybe types of slabs? > CPU > CPU_PARTIAL > PARTIAL > FULL > > And in sysfs, it use show_slab_objects() and cpu_partial_slabs_show() to > reflect the statistics. > > In patch 2, it splits some function in show_slab_objects() which makes sure > only cpu_partial_slabs_show() covers statistics for CPU_PARTIAL slabs. > > After doing so, it would be more clear that show_slab_objects() has totally 9 > statistic combinations for three level of slabs. Each slab has three cases > statistic. > > slabs > objects > total_objects That sounds good. > which is a little bit hard for users to understand. The second three patches > rename sysfs file in this pattern. > > xxx_slabs[[_total]_objects] > > Finally it looks Like > > slabs > slabs_objects > slabs_total_objects > cpu_slabs > cpu_slabs_objects > cpu_slabs_total_objects > partial_slabs > partial_slabs_objects > partial_slabs_total_objects > cpu_partial_slabs Arent we missing: cpu_partial_slabs_objects cpu_partial_slabs_total_objects And the partial slabs exclude the cpu slabs as well as the cpu_partial slabs? Could you add some documentation as well to explain the exact semantics? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
