On Wed, May 03, 2017 at 02:24:48PM -0400, Rik van Riel wrote: > On Tue, 2017-05-02 at 17:27 -0400, Josef Bacik wrote: > > > + /* > > + * If we don't have a lot of inactive or slab pages then > > there's no > > + * point in trying to free them exclusively, do the normal > > scan stuff. > > + */ > > + if (nr_inactive < total_high_wmark && nr_slab < > > total_high_wmark) > > + sc->inactive_only = 0; > > This part looks good. Below this point, there is obviously no > point in skipping the active list. > > > + if (!global_reclaim(sc)) > > + sc->inactive_only = 0; > > Why the different behaviour with and without cgroups? > > Have you tested both of these? > Huh oops I thought I deleted that, sorry I'll kill that part. > > + /* > > + * We still want to slightly prefer slab over inactive, so > > if inactive > > + * is large enough just skip slab shrinking for now. If we > > aren't able > > + * to reclaim enough exclusively from the inactive lists > > then we'll > > + * reset this on the first loop and dip into slab. > > + */ > > + if (nr_inactive > total_high_wmark && nr_inactive > nr_slab) > > + skip_slab = true; > > I worry that this may be a little too aggressive, > and result in the slab cache growing much larger > than it should be on some systems. > > I wonder if it may make more sense to have the > aggressiveness of slab scanning depend on the > ratio of inactive to reclaimable slab pages, rather > than having a hard cut-off like this? > So I originally had a thing that kept track of the rate of change of inactive vs slab between kswapd runs, but this worked fine so I figured simpler was better. Keep in mind that we only skip slab the first loop through, so if we fail to free enough on the inactive list the first time through then we start evicting slab as well. The idea is (and my testing bore this out) that with the new size ratio way of shrinking slab we would sometimes be over zealous and evict slab that we were actively using, even though we had reclaimed plenty of pages from our inactive list to satisfy our sc->nr_to_reclaim. I could probably change the ratio in the sc->inactive_only case to be based on the slab to inactive ratio and see how that turns out, I'll get that wired up and let you know how it goes. Thanks, Josef -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
