Re: [PATCH 1/4] Add kswapd descriptor.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed,  8 Dec 2010 16:22:30 +0900 (JST)
KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> wrote:

> > > +struct kswapd {
> > > +	struct task_struct *kswapd_task;
> > > +	wait_queue_head_t kswapd_wait;
> > > +	struct mem_cgroup *kswapd_mem;
> > > +	pg_data_t *kswapd_pgdat;
> > > +};
> > > +
> > > +#define MAX_KSWAPDS MAX_NUMNODES
> > > +extern struct kswapd kswapds[MAX_KSWAPDS];
> > 
> > This is potentially very large for a static structure. Can they not be
> > dynamically allocated and kept on a list? Yes, there will be a list walk
> > involved if yonu need a particular structure but that looks like it's a
> > rare operation at this point.
> 
> Why can't we use normal workqueue mechanism?
> 
Sounds much simpler than self management of threads.

My only concern is cpu-time-stealing by background works but ....

Thanks,
-Kame

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]