On Mon, 10 Apr 2017 20:58:13 +0900 Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx> wrote: > Patch "mm: page_alloc: __GFP_NOWARN shouldn't suppress stall warnings" > changed to drop __GFP_NOWARN when calling warn_alloc() for stall warning. > Although I suggested for two times to drop __GFP_NOWARN when warn_alloc() > for stall warning was proposed, Michal Hocko does not want to print stall > warnings when __GFP_NOWARN is given [1][2]. > > "I am not going to allow defining a weird __GFP_NOWARN semantic which > allows warnings but only sometimes. At least not without having a proper > way to silence both failures _and_ stalls or just stalls. I do not > really thing this is worth the additional gfp flag." I interpret __GFP_NOWARN to mean "don't warn about this allocation attempt failing", not "don't warn about anything at all". It's a very minor issue but yes, methinks that stall warning should still come out. Unless it's known to cause a problem for the stall warning to come out for __GFP_NOWARN attempts? If so then perhaps a __GFP_NOWARN_ABOUT_STALLS is needed? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
