JFTR. Joe, has already noticed this http://lkml.kernel.org/r/2aaf6f1701ee78582743d91359018689d5826e82.1489628459.git.joe@xxxxxxxxxxx and I have requested to split out the fix from the rest of the whitespace noise http://lkml.kernel.org/r/20170316105733.GC30508@xxxxxxxxxxxxxx but Joe hasn't really followed up and I didn't get to do it myself. On Mon 03-04-17 15:11:17, Andrew Morton wrote: > From: Alexander Polakov <apolyakov@xxxxxxxx> > Subject: mmpage_alloc.c: fix print order in show_free_areas() > > Fixes: 11fb998986a72a ("mm: move most file-based accounting to the node") > Link: http://lkml.kernel.org/r/1490377730.30219.2.camel@xxxxxxxx > Signed-off-by: Alexander Polyakov <apolyakov@xxxxxxxxx> > Cc: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx> > Cc: Vlastimil Babka <vbabka@xxxxxxx> > Cc: Michal Hocko <mhocko@xxxxxxxx> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Even though this cannot cause any crash or misbehaving it is still confusing enough to be worth backporting to stable Cc: stable # 4.8+ Acked-by: Michal Hocko <mhocko@xxxxxxxx> Thanks! > --- > > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -puN mm/page_alloc.c~fix-print-order-in-show_free_areas mm/page_alloc.c > --- a/mm/page_alloc.c~fix-print-order-in-show_free_areas > +++ a/mm/page_alloc.c > @@ -4519,13 +4519,13 @@ void show_free_areas(unsigned int filter > K(node_page_state(pgdat, NR_FILE_MAPPED)), > K(node_page_state(pgdat, NR_FILE_DIRTY)), > K(node_page_state(pgdat, NR_WRITEBACK)), > + K(node_page_state(pgdat, NR_SHMEM)), > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > K(node_page_state(pgdat, NR_SHMEM_THPS) * HPAGE_PMD_NR), > K(node_page_state(pgdat, NR_SHMEM_PMDMAPPED) > * HPAGE_PMD_NR), > K(node_page_state(pgdat, NR_ANON_THPS) * HPAGE_PMD_NR), > #endif > - K(node_page_state(pgdat, NR_SHMEM)), > K(node_page_state(pgdat, NR_WRITEBACK_TEMP)), > K(node_page_state(pgdat, NR_UNSTABLE_NFS)), > node_page_state(pgdat, NR_PAGES_SCANNED), > _ > > Patches currently in -mm which might be from apolyakov@xxxxxxxx are > > fix-print-order-in-show_free_areas.patch > -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
