On Wed, Mar 29, 2017 at 05:52:43PM +0200, Dmitry Vyukov wrote: > On Wed, Mar 29, 2017 at 4:00 PM, Mark Rutland <mark.rutland@xxxxxxx> wrote: > > On Tue, Mar 28, 2017 at 06:15:44PM +0200, Dmitry Vyukov wrote: > >> KASAN uses compiler instrumentation to intercept all memory accesses. > >> But it does not see memory accesses done in assembly code. > >> One notable user of assembly code is atomic operations. Frequently, > >> for example, an atomic reference decrement is the last access to an > >> object and a good candidate for a racy use-after-free. > >> > >> Add manual KASAN checks to atomic operations. > >> > >> Signed-off-by: Dmitry Vyukov <dvyukov@xxxxxxxxxx> > >> Cc: Mark Rutland <mark.rutland@xxxxxxx> > >> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx> > >> Cc: Will Deacon <will.deacon@xxxxxxx>, > >> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, > >> Cc: Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx>, > >> Cc: Ingo Molnar <mingo@xxxxxxxxxx>, > >> Cc: kasan-dev@xxxxxxxxxxxxxxxx > >> Cc: linux-mm@xxxxxxxxx > >> Cc: linux-kernel@xxxxxxxxxxxxxxx > >> Cc: x86@xxxxxxxxxx > > > > FWIW, I think that structuring the file this way will make it easier to > > add the {acquire,release,relaxed} variants (as arm64 will need), > > so this looks good to me. > > > > As a heads-up, I wanted to have a go at that, but I wasn't able to apply > > patch two onwards on v4.11-rc{3,4} or next-20170329. I was not able to > > cleanly revert the instrumentation patches currently in next-20170329, > > since other patches built atop of them. > > I based it on git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > locking/core Ah; I should have guessed. ;) Thanks for the pointer! I'll give that a go shortly. Thanks, Mark. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>