On March 25, 2017 7:48 PM Alexey Perevalov wrote: > On 03/23/2017 12:42 PM, Hillf Danton wrote: > > On March 23, 2017 2:29 AM Alexey Perevalov wrote: > >> static inline struct uffd_msg userfault_msg(unsigned long address, > >> unsigned int flags, > >> - unsigned long reason) > >> + unsigned long reason, > >> + unsigned int features) > > Nit: the type of feature is u64 by define. > > Yes, let me clarify once again, Thanks:) > type of features is u64, but in struct uffdio_api, which used for handling > UFFDIO_API. > Function userfault_msg is using in handle_userfault, when only > context (struct userfaultfd_ctx) is available, features inside context is > type of unsigned int and uffd_ctx_features is using for casting. > It's more likely question to maintainer, but due to userfaultfd_ctx is > internal only > structure, it's not a big problem to extend it in the future. > You are right. Hillf -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
