On Thu, Dec 2, 2010 at 9:29 AM, KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> wrote: >> > It might work well. but I don't like such a coding that kswapd_try_to_sleep's >> > eturn value is order. It doesn't look good to me and even no comment. Hmm.. >> > >> > How about this? >> > If you want it, feel free to use it. >> > If you insist on your coding style, I don't have any objection. >> > Then add My Reviewed-by. >> > >> > Signed-off-by: Minchan Kim <minchan.kim@xxxxxxxxx> >> >> I'm ok this. >> >> Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> >> >> >> Thanks. >> > > Please consider rensend a patch with full patch description. Of cource, > you need to rebase this on top Mel's patch. > > Plus, please don't remove Shaohua's reported-by tag. It's important line > than my code. Please respect good bug finder. I don't have a thought to intercept Shaohua and Your's credit. Just a review so I hoped you send the patch with adding my signed-off or reviewed-by. Okay. I will resend it with full-description and you guys's signed-off. But before that, We have to discuss Shaohua's argue about _safety_. > Thanks. > > > > -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href