On 03/09/2017 05:31 PM, Thomas Garnier wrote: > On Thu, Mar 9, 2017 at 2:13 PM, Boris Ostrovsky > <boris.ostrovsky@xxxxxxxxxx> wrote: >>>> I don't have any experience with Xen so it would be great if virtme can test it. >>> I am pretty sure I tested this series at some point but I'll test it again. >>> >> >> Fails 32-bit build: >> >> >> /home/build/linux-boris/arch/x86/kvm/vmx.c: In function ‘segment_base’: >> /home/build/linux-boris/arch/x86/kvm/vmx.c:2054: error: ‘host_gdt’ >> undeclared (first use in this function) >> /home/build/linux-boris/arch/x86/kvm/vmx.c:2054: error: (Each undeclared >> identifier is reported only once >> /home/build/linux-boris/arch/x86/kvm/vmx.c:2054: error: for each >> function it appears in.) >> /home/build/linux-boris/arch/x86/kvm/vmx.c:2054: error: type defaults to >> ‘int’ in declaration of ‘type name’ >> /home/build/linux-boris/arch/x86/kvm/vmx.c:2054: error: type defaults to >> ‘int’ in declaration of ‘type name’ >> /home/build/linux-boris/arch/x86/kvm/vmx.c:2054: warning: initialization >> from incompatible pointer type >> /home/build/linux-boris/arch/x86/kvm/vmx.c:2054: warning: unused >> variable ‘gdt’ >> >> >> -boris > It seems that I forgot to remove line 2054 on the rebase. My 32-bit > build comes clean but I assume it is not good enough compare to the > full version I build for 64-bit KVM testing. > > Remove just this line and it should build fine, I will fix this on the > next iteration. > > Thanks for testing, > So this, in fact, does break Xen in that the hypercall to set GDT fails. I will have lo look at this tomorrow but I definitely at least built with v3 of this series. And I don't see why I wouldn't have tested it once I built it. -boris -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
