On Mon 27-02-17 08:13:10, Shaohua Li wrote: > On Mon, Feb 27, 2017 at 03:28:01PM +0900, Minchan Kim wrote: [...] > > This patch doesn't address I pointed out in v4. > > > > https://marc.info/?i=20170224233752.GB4635%40bbox > > > > Let's discuss it if you still are against. > > I really think a spearate patch makes the code clearer. There are a lot of > places we introduce a function but don't use it immediately, if the way makes > the code clearer. But anyway, I'll let Andrew decide if the two patches should > be merged. I agree that it is almost always _preferable_ to add new functions along with their callers. In this particular case I would lean towards keeping the separation the way Shaohua did it because it makes the code really cleaner IMHO. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
