Re: [RFC 0/3] Regressions due to 7b79d10a2d64 ("mm: convert kmalloc_section_memmap() to populate_section_memmap()") and Kasan initialization on

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 15, 2017 at 1:10 PM, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, 15 Feb 2017 21:58:23 +0100 Nicolai Stange <nicstange@xxxxxxxxx> wrote:
>
>> Hi Dan,
>>
>> your recent commit 7b79d10a2d64 ("mm: convert kmalloc_section_memmap() to
>> populate_section_memmap()") seems to cause some issues with respect to
>> Kasan initialization on x86.
>>
>> This is because Kasan's initialization (ab)uses the arch provided
>> vmemmap_populate().
>>
>> The first one is a boot failure, see [1/3]. The commit before the
>> aforementioned one works fine.
>>
>> The second one, i.e. [2/3], is something that hit my eye while browsing
>> the source and I verified that this is indeed an issue by printk'ing and
>> dumping the page tables.
>>
>> The third one are excessive warnings from vmemmap_verify() due to Kasan's
>> NUMA_NO_NODE page populations.
>
> urggggh.
>
> That means these two series:
>
> mm-fix-type-width-of-section-to-from-pfn-conversion-macros.patch
> mm-devm_memremap_pages-use-multi-order-radix-for-zone_device-lookups.patch
> mm-introduce-struct-mem_section_usage-to-track-partial-population-of-a-section.patch
> mm-introduce-common-definitions-for-the-size-and-mask-of-a-section.patch
> mm-cleanup-sparse_init_one_section-return-value.patch
> mm-track-active-portions-of-a-section-at-boot.patch
> mm-track-active-portions-of-a-section-at-boot-fix.patch
> mm-track-active-portions-of-a-section-at-boot-fix-fix.patch
> mm-fix-register_new_memory-zone-type-detection.patch
> mm-convert-kmalloc_section_memmap-to-populate_section_memmap.patch
> mm-prepare-for-hot-add-remove-of-sub-section-ranges.patch
> mm-support-section-unaligned-zone_device-memory-ranges.patch
> mm-support-section-unaligned-zone_device-memory-ranges-fix.patch
> mm-support-section-unaligned-zone_device-memory-ranges-fix-2.patch
> mm-enable-section-unaligned-devm_memremap_pages.patch
> libnvdimm-pfn-dax-stop-padding-pmem-namespaces-to-section-alignment.patch
>

Yes, let's drop these and try again for 4.12. Thanks for the report
and the debug Nicolai!

> and
>
> mm-devm_memremap_pages-hold-device_hotplug-lock-over-mem_hotplug_begin-done.patch
> mm-validate-device_hotplug-is-held-for-memory-hotplug.patch

No, these are separate and are still valid for the merge window.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]
  Powered by Linux