"Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxxxxxxxxxx> writes: > Michael Ellerman <mpe@xxxxxxxxxxxxxx> writes: > >> "Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxxxxxxxxxx> writes: >>> diff --git a/arch/powerpc/include/asm/book3s/64/mmu-hash.h b/arch/powerpc/include/asm/book3s/64/mmu-hash.h >>> index 0735d5a8049f..8720a406bbbe 100644 >>> --- a/arch/powerpc/include/asm/book3s/64/mmu-hash.h >>> +++ b/arch/powerpc/include/asm/book3s/64/mmu-hash.h >>> @@ -16,6 +16,9 @@ >>> #include <asm/page.h> >>> #include <asm/bug.h> >>> >>> +#ifndef __ASSEMBLY__ >>> +#include <linux/mmdebug.h> >>> +#endif >> >> I assume that's for the VM_BUG_ON() you add below. But if so wouldn't >> the #include be better placed in book3s/64/pgtable.h also? > > mmu-hash.h has got a hack that is explained below > > #ifndef __ASSEMBLY__ > #include <linux/mmdebug.h> > #endif > /* > * This is necessary to get the definition of PGTABLE_RANGE which we > * need for various slices related matters. Note that this isn't the > * complete pgtable.h but only a portion of it. > */ > #include <asm/book3s/64/pgtable.h> > > This is the only place where we do that book3s/64/pgtable.h include this > way. Everybody should include asm/pgable.h which picks the righ version > based on different config option. I don't understand how that is related. If you're adding a VM_BUG_ON() in book3s/64/pgtable.h, why isn't the include of mmdebug.h in that file also? cheers -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
