On Mon, Nov 29, 2010 at 02:38:01PM +0900, Daisuke Nishimura wrote: > I think this should be: > > if (unlikely(mem_cgroup_newpage_charge(new_page, mm, GFP_KERNEL))) { > #ifdef CONFIG_NUMA > put_page(new_page); > #endif > goto out; > } Hmm no, the change you suggest would generate memory corruption with use after free. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>