> The nr_dirty_[background_]threshold fields are misplaced before the > numa_* fields, and users will read strange values. > > This is the right order. Before patch, nr_dirty_background_threshold > will read as 0 (the value from numa_miss). > > numa_hit 128501 > numa_miss 0 > numa_foreign 0 > numa_interleave 7388 > numa_local 128501 > numa_other 0 > nr_dirty_threshold 144291 > nr_dirty_background_threshold 72145 > > Cc: Michael Rubin <mrubin@xxxxxxxxxx> > Signed-off-by: Wu Fengguang <fengguang.wu@xxxxxxxxx> Obviously. :-/ Thanks, Wu. Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> > --- > mm/vmstat.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- linux-next.orig/mm/vmstat.c 2010-11-28 16:02:12.000000000 +0800 > +++ linux-next/mm/vmstat.c 2010-11-28 16:02:24.000000000 +0800 > @@ -750,8 +750,6 @@ static const char * const vmstat_text[] > "nr_shmem", > "nr_dirtied", > "nr_written", > - "nr_dirty_threshold", > - "nr_dirty_background_threshold", > > #ifdef CONFIG_NUMA > "numa_hit", > @@ -761,6 +759,8 @@ static const char * const vmstat_text[] > "numa_local", > "numa_other", > #endif > + "nr_dirty_threshold", > + "nr_dirty_background_threshold", > > #ifdef CONFIG_VM_EVENT_COUNTERS > "pgpgin", > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@xxxxxxxxxx For more info on Linux MM, > see: http://www.linux-mm.org/ . > Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ > Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>