On Fri 03-02-17 14:31:22, Dave Jiang wrote: > Since the introduction of FAULT_FLAG_SIZE to the vm_fault flag, it has > been somewhat painful with getting the flags set and removed at the > correct locations. More than one kernel oops was introduced due to > difficulties of getting the placement correctly. Removing the flag > values and introducing an input parameter to huge_fault that indicates > the size of the page entry. This makes the code easier to trace and > should avoid the issues we see with the fault flags where removal of the > flag was necessary in the fallback paths. > > Signed-off-by: Dave Jiang <dave.jiang@xxxxxxxxx> Yeah, the code looks less error-prone this way. I like it. You can add: Reviewed-by: Jan Kara <jack@xxxxxxx> Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
