On Mon, Nov 29, 2010 at 1:28 PM, Rik van Riel <riel@xxxxxxxxxx> wrote: > On 11/28/2010 10:02 AM, Minchan Kim wrote: >> >> Now zap_pte_range alwayas promotes pages which are pte_young&& >> !VM_SequentialReadHint(vma). But in case of calling MADV_DONTNEED, >> it's unnecessary since the page wouldn't use any more. >> >> If the page is sharred by other processes and it's real working set > > This line seems to be superfluous, I don't see any special > treatment for this case in the code. I should remove the lines. It's my fault. > >> Signed-off-by: Minchan Kim<minchan.kim@xxxxxxxxx> >> Cc: Rik van Riel<riel@xxxxxxxxxx> >> Cc: KOSAKI Motohiro<kosaki.motohiro@xxxxxxxxxxxxxx> >> Cc: Johannes Weiner<hannes@xxxxxxxxxxx> >> Cc: Nick Piggin<npiggin@xxxxxxxxx> >> Cc: Mel Gorman<mel@xxxxxxxxx> >> Cc: Wu Fengguang<fengguang.wu@xxxxxxxxx> > > The patch itself looks good to me. > > Acked-by: Rik van Riel <riel@xxxxxxxxxx> Thanks, Rik. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>