On Mon 30-01-17 22:59:52, Yisheng Xie wrote: > Hi， Michal， > Sorry for late reply. > > On 01/26/2017 05:18 PM, Michal Hocko wrote: > > On Wed 25-01-17 23:05:37, ysxie@xxxxxxxxxxx wrote: > >> From: Yisheng Xie <xieyisheng1@xxxxxxxxxx> > >> > >> Define isolate_movable_page as a static inline function when > >> CONFIG_MIGRATION is not enable. It should return false > >> here which means failed to isolate movable pages. > >> > >> This patch do not have any functional change but prepare for > >> later patch. > > I think it would make more sense to make isolate_movable_page return int > > and have the same semantic as __isolate_lru_page. This would be a better > > preparatory patch for the later work. > Yes, I think you are right, it is better to make isolate_movable_page return int > just as what isolate_lru_page do, to make a better code style. > > It seems Andrew had already merged the fixed patch from Arnd Bergmann, > Maybe I can rewrite it in a later patch if it is suitable :) I guess Andrew can just drop the current series with the folow up fixes and wait for your newer version. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
