On Wed, Nov 03, 2010 at 04:27:46PM +0100, Andrea Arcangeli wrote: > @@ -543,6 +554,18 @@ static inline void set_pte_at(struct mm_ > PVOP_VCALL4(pv_mmu_ops.set_pte_at, mm, addr, ptep, pte.pte); > } > > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > +static inline void set_pmd_at(struct mm_struct *mm, unsigned long addr, > + pmd_t *pmdp, pmd_t pmd) > +{ > + if (sizeof(pmdval_t) > sizeof(long)) > + /* 5 arg words */ > + pv_mmu_ops.set_pmd_at(mm, addr, pmdp, pmd); > + else > + PVOP_VCALL4(pv_mmu_ops.set_pmd_at, mm, addr, pmdp, pmd.pmd); > +} > +#endif > + > static inline void set_pmd(pmd_t *pmdp, pmd_t pmd) > { > pmdval_t val = native_pmd_val(pmd); btw, I noticed the 32bit build with HIGHMEM off, paravirt on, and THP on fails without this below change (that configuration clearly has never been tested for build), so I'm merging this in the above quoted patch. diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -558,11 +558,13 @@ static inline void set_pte_at(struct mm_ static inline void set_pmd_at(struct mm_struct *mm, unsigned long addr, pmd_t *pmdp, pmd_t pmd) { +#if PAGETABLE_LEVELS >= 3 if (sizeof(pmdval_t) > sizeof(long)) /* 5 arg words */ pv_mmu_ops.set_pmd_at(mm, addr, pmdp, pmd); else PVOP_VCALL4(pv_mmu_ops.set_pmd_at, mm, addr, pmdp, pmd.pmd); +#endif } #endif -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>