On Wed, Jan 25, 2017 at 08:55:22AM -0800, Srikar Dronamraju wrote: > > > > > > > For THPs page_check_address() always fails. It's better to split them > > > > first before trying to replace. > > > > > > So what does this mean. uprobes simply fails to work when trying to > > > place a probe into a THP memory region? > > > > Looks like we can end up with endless retry loop in uprobe_write_opcode(). > > > > > How come nobody noticed (and reported) this when using the feature? > > > > I guess it's not often used for anon memory. > > > > The first time the breakpoint is hit on a page, it replaces the text > page with anon page. Now lets assume we insert breakpoints in all the > pages in a range. Here each page is individually replaced by a non THP > anonpage. (since we dont have bulk breakpoint insertion support, > breakpoint insertion happens one at a time). Now the only interesting > case may be when each of these replaced pages happen to be physically > contiguous so that THP kicks in to replace all of these pages with one > THP page. Can happen in practice? The problem is with the page you try to replace, not with page that you replace it with. > Are there any other cases that I have missed? The binary on tmpfs with huge pages. I wrote test-case that triggers the problem. -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
