On Fri, Jan 20, 2017 at 04:33:08PM -0700, Dave Jiang wrote: > ->fault(), ->page_mkwrite(), and ->pfn_mkwrite() calls do not need to take > a vma and vmf parameter when the vma already resides in vmf. Remove the vma > parameter to simplify things. > > Signed-off-by: Dave Jiang <dave.jiang@xxxxxxxxx> > --- > > This patch has received a build success notification from the 0day-kbuild > robot across 124 configs. > > --- <> > diff --git a/arch/x86/entry/vdso/vma.c b/arch/x86/entry/vdso/vma.c > index 10820f6..b6661fd 100644 > --- a/arch/x86/entry/vdso/vma.c > +++ b/arch/x86/entry/vdso/vma.c > @@ -38,7 +38,7 @@ void __init init_vdso_image(const struct vdso_image *image) > struct linux_binprm; > > static int vdso_fault(const struct vm_special_mapping *sm, > - struct vm_area_struct *vma, struct vm_fault *vmf) > + struct vm_area_struct *vma, struct vm_fault *vmf) Unneeded spacing change. Other than that, this looks good to me. I agree with Jan's observation that it creates a lot of thrash, but I personally like the change because it eliminates the question of what to do when the 'vma' you're passed in doesn't match 'vmf->vma'. Having one source of truth seems good, and it reduces the amount of args we are passing around. Reviewed-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
