On Mon, Jan 23, 2017 at 04:13:39PM +0900, Sergey Senozhatsky wrote: > On (01/23/17 15:27), Joonsoo Kim wrote: > > Hello, > > > > Think about following case in 64 bits kernel. > > > > If value pattern in the page is like as following, we cannot detect > > the same page with 'unsigned int' element. > > > > AAAAAAAABBBBBBBBAAAAAAAABBBBBBBB... > > > > 4 bytes is 0xAAAAAAAA and next 4 bytes is 0xBBBBBBBB and so on. > > yep, that's exactly the case that I though would be broken > with a 4-bytes pattern matching. so my conlusion was that > for 4 byte pattern we would have working detection anyway, > for 8 bytes patterns we might have some extra matching. > not sure if it matters that much though. It would be better for deduplication as pattern coverage is bigger and we cannot guess all of patterns now so it would be never ending story(i.e., someone claims 16bytes pattern matching would be better). So, I want to make that path fast rather than increasing dedup ratio if memset is really fast rather than open-looping. So in future, if we can prove bigger pattern can increase dedup ratio a lot, then, we could consider to extend it at the cost of make that path slow. In summary, zhouxianrong, please test pattern as Joonsoo asked. So if there are not much benefit with 'long', let's go to the 'int' with memset. And Please resend patch if anyone dosn't oppose strongly by the time. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
