On Fri, Jan 13, 2017 at 09:26:08AM +0100, Michal Hocko wrote: > On Fri 13-01-17 11:16:10, Dan Carpenter wrote: > > On Thu, Jan 12, 2017 at 08:33:27PM +0100, Michal Hocko wrote: > > > On Thu 12-01-17 22:20:52, Dan Carpenter wrote: > > > > kunmap_atomic() and kunmap() take different pointers. People often get > > > > these mixed up. > > > > > > > > Fixes: 16374db2e9a0 ("userfaultfd: hugetlbfs: fix __mcopy_atomic_hugetlb retry/error processing") > > > > > > This looks like a linux-next sha1. This is not stable and will change... > > > > > > > Yeah. But probably Andrew is just going to fold it into the original > > anyway. Probably most of linux-next trees don't rebase so the hash is > > good and the people who rebase fold it in so it doesn't show up in the > > released code. It basically never hurts to have the Fixes tag. > > Yeah, I have a vague recollection that some of those sha1 leaked to > Linus. Do not have any examples handy though. It is true that Andrew > folds those fixes into the original patch so it might be helpful to > have > Fixes: mmotm-patch-file-name.patch I have no idea how to do that. I'm always just working on linux-next and not the individual trees... I'm interested to hear from Andrew what's easiest because I don't know at all how quilt works. My work flow is that I have scripts to generate patches from within vim. Most of the time I'm just working on one file but occasionally I will combine two patches together in mutt. For Dave's networking patches I have a separate git tree where I try to apply them to net and then net-next to see which tree it should go into. Otherwise, I generally assume the maintainer knows which tree they belong in. regards, dan carpenter -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>