Re: [PATCH 03/13] writeback: per-task rate limit on balance_dirty_pages()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2010-11-17 at 12:27 +0800, Wu Fengguang wrote:
> +       if (unlikely(current->nr_dirtied >= current->nr_dirtied_pause ||
> +                    bdi->dirty_exceeded)) {
> +               balance_dirty_pages(mapping, current->nr_dirtied);
> +               current->nr_dirtied = 0;
>         } 

Was it a conscious choice to use
  current->nr_dirtied = 0
over 
  current->nr_dirtied -= current->nr_dirtied_pause
?

The former will cause a drift in pause times due to truncation of the
excess.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]